[Asterisk-code-review] Changed app amd for ASTERISK-28143 (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10707 )

Change subject: Changed app_amd for ASTERISK-28143
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10707/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10707/1//COMMIT_MSG@7
PS1, Line 7: Changed app_amd for ASTERISK-28143
This commit message needs to be formed according to the wiki[1].

[1] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/10707/1/apps/app_amd.c
File apps/app_amd.c:

https://gerrit.asterisk.org/#/c/10707/1/apps/app_amd.c@287
PS1, Line 287: 		}		
Added red space.


https://gerrit.asterisk.org/#/c/10707/1/apps/app_amd.c@298
PS1, Line 298: 		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG || f->frametype == AST_FRAME_NULL) {
The removal of AST_FRAME_NULL was done as a result of an earlier change[1] to app_amd to fix a problem encountered by another individual. I think more information about the scenario and usage needs to be provided in the issue before accepting this - specifically what channel drivers are in use and what silence actually means.

[1] https://gerrit.asterisk.org/#/c/asterisk/+/8389/



-- 
To view, visit https://gerrit.asterisk.org/10707
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4fe35be6bd9683bc1ae01b884d7a544c128d3b6
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 26 Nov 2018 12:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181126/dd25e282/attachment.html>