[Asterisk-code-review] astobj2: Eliminate usage of legacy ao2 container alloc routine. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10698 )

Change subject: astobj2: Eliminate usage of legacy ao2_container_alloc routine.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Minor nits

https://gerrit.asterisk.org/#/c/10698/1/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10698/1/apps/app_queue.c@2702
PS1, Line 2702: 			/* linear strategy depends on order, so we have to place all members in a single bucket */
s/single bucket/list/


https://gerrit.asterisk.org/#/c/10698/1/tests/test_astobj2.c
File tests/test_astobj2.c:

https://gerrit.asterisk.org/#/c/10698/1/tests/test_astobj2.c@464
PS1, Line 464: 		ast_test_status_update(test, "ao2_container_alloc_list failed.\n");
Since there are different kinds of containers that could have failed:
s/_list/_xxx/

Either that or revert this change.



-- 
To view, visit https://gerrit.asterisk.org/10698
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0907d78bc66efc775672df37c8faad00f2f6c088
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 14:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181121/b0f29301/attachment.html>