[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10704 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 1:

(1 comment)

I intend to backport this to 13 once I get feedback.  The only difference for Asterisk 13 is lack of AST_MODULE_SELF so ast_module_info->self will have to be used.

I'm unsure if this requires mention in CHANGES and/or UPGRADE?

https://gerrit.asterisk.org/#/c/10704/1/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/#/c/10704/1/include/asterisk/res_pjsip_session.h@588
PS1, Line 588: #define ast_sip_session_register_supplement(supplement) \
This is technically a breaking change.  Asterisk 16.0.0 will reject modules which use ast_sip_session_register_supplement() that are compiled with this updated header due to missing symbol.  This will not result in a crash.  Modules compiled against Asterisk 16.0.0 will continue to work even after this patch but they will lack protection against unsafe module unload.



-- 
To view, visit https://gerrit.asterisk.org/10704
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10704
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 14:12:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181121/20b685dd/attachment.html>