[Asterisk-code-review] astobj2: Create function to copy weak proxied objects from c... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10638 )

Change subject: astobj2: Create function to copy weak proxied objects from container.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10638/1/include/asterisk/astobj2.h
File include/asterisk/astobj2.h:

https://gerrit.asterisk.org/#/c/10638/1/include/asterisk/astobj2.h@1425
PS1, Line 1425:  * \param dest Container to copy src object references into.
              :  * \param src Container to copy all object references from.
Need to state which containers need to be weak/strong containers since the commit message is not a good place to document function requirements.  It looks like the src container must be a weak container and the dest container must be strong.


https://gerrit.asterisk.org/#/c/10638/1/tests/test_astobj2_weaken.c
File tests/test_astobj2_weaken.c:

https://gerrit.asterisk.org/#/c/10638/1/tests/test_astobj2_weaken.c@313
PS1, Line 313: 	} while(0) \
* No need for the trailing \
* Space between while (0)


https://gerrit.asterisk.org/#/c/10638/1/tests/test_astobj2_weaken.c@320
PS1, Line 320: 	} while(0) \
same



-- 
To view, visit https://gerrit.asterisk.org/10638
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I898387f058057e08696fe9070f8cd94ef3a27482
Gerrit-Change-Number: 10638
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 13:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181121/dd91f4f1/attachment.html>