[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10617 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 10: Code-Review+1

This looks good for master.  Backporting to 13/16 will be difficult - we will not be able to make changes to the definition of 'struct ast_sip_session_supplement'.  Instead we'll need to create a private structure such as:
struct private_sip_session_supplement {
  struct ast_sip_session_supplement public;
  struct ast_module *module;
};

Then ast_sip_session_register_supplement_with_module will need to allocate the private_sip_session_supplement, copy everything from the public structure and set module.

In addition we'll need to provide an ABI compatible ast_sip_session_register_supplement function (this is relatively easy).

Let me know if this is something you feel up to or if you'd like someone to handle the backport.


-- 
To view, visit https://gerrit.asterisk.org/10617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 10
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 00:01:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181120/0f412f36/attachment.html>