[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10617 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

Just a couple nits and I'll be happy with this patch for 'master'.  Getting this patch into 13/16 will be more difficult as we need to maintain compatibility with existing binary modules.

https://gerrit.asterisk.org/#/c/10617/9/res/res_pjsip/pjsip_message_filter.c
File res/res_pjsip/pjsip_message_filter.c:

https://gerrit.asterisk.org/#/c/10617/9/res/res_pjsip/pjsip_message_filter.c@529
PS9, Line 529: 	ast_sip_session_register_supplement_with_module(module, &filter_session_supplement);
In Asterisk 16+ we can just use ast_sip_session_register_supplement(&filter_session_supplement) from here.  AST_MODULE_SELF works from here.  That is why I suggested that ast_res_pjsip_init_message_filter does not need any arguments.


https://gerrit.asterisk.org/#/c/10617/9/res/res_pjsip/pjsip_session.c
File res/res_pjsip/pjsip_session.c:

https://gerrit.asterisk.org/#/c/10617/9/res/res_pjsip/pjsip_session.c@102
PS9, Line 102: 		/* referenced session created. increasing modue reference. */
spelling modue -> module



-- 
To view, visit https://gerrit.asterisk.org/10617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 9
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 23:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181120/688f8d11/attachment.html>