[Asterisk-code-review] RTP: need to reset DTMF last seqno/timestamp on voice packet... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10623 )

Change subject: RTP: need to reset DTMF last seqno/timestamp on voice packet with marker bit
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10623/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/10623/1/res/res_rtp_asterisk.c@5729
PS1, Line 5729: 		/* The marker bit set on the voice packet indicates the start
              : 		 * of a new stream and a new time stamp. Need to reset the DTMF
              : 		 * last sequence number and the timestamp of the last END packet.
              : 		 */
Is this always the case? Seems like if it is a new stream then the ssrc would have changed? Which is checked a little above this section of code where these fields are reset then.

I guess I am wondering why the change was not picked up then?



-- 
To view, visit https://gerrit.asterisk.org/10623
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c5742158fa836ad549713a9814d46a5d2b1620
Gerrit-Change-Number: 10623
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 22:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181120/8ac90471/attachment.html>