[Asterisk-code-review] ast restart: re-enable test (testsuite[16])

Joshua Colp asteriskteam at digium.com
Tue Nov 20 04:32:43 CST 2018


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10696 )

Change subject: ast_restart: re-enable test
......................................................................

ast_restart: re-enable test

This test was sporadically failing due to file writes occasionally taking too
long. The ast_db sync thread would block long enough for even a 2 second
retransmission timer to time out. The retransmission would be sent, thus
failing the test. This appeared to only happen when running in a docker
container on the test infrastructure.

Updates have been made to the test infrastructure that allow test containers
to now use a tmpfs, which should hopefully completely alleviate the problem.

ASTERISK-28088

Change-Id: I6b3fef60d20ff9830a1149b26b5bd4c34a2dbb73
---
M tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml b/tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml
index 56b8e8e..e066c22 100644
--- a/tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml
+++ b/tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml
@@ -1,5 +1,4 @@
 testinfo:
-    skip: 'See ASTERISK-28088'
     summary: 'Test subscription persistence over Asterisk restarts'
     description: |
         Tests that subscriptions survive an Asterisk restart.

-- 
To view, visit https://gerrit.asterisk.org/10696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b3fef60d20ff9830a1149b26b5bd4c34a2dbb73
Gerrit-Change-Number: 10696
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181120/abe65bd4/attachment-0001.html>


More information about the asterisk-code-review mailing list