[Asterisk-code-review] res pjsip caller id: Use static pj str t for fromto header n... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10652 )

Change subject: res_pjsip_caller_id: Use static pj_str_t for fromto header names.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10652/1/res/res_pjsip_caller_id.c
File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/#/c/10652/1/res/res_pjsip_caller_id.c@784
PS1, Line 784: 	ast_module_shutdown_ref(ast_module_info->self);
> There is another patch currently up for making it so session supplements can't be unloaded while a s […]
I can do a complete review on that one tomorrow.  On quick glance that patch breaks the ABI of session supplement modules so we'll need to find a way to deal with that.  I think this patch is ready to go now and fixes one of the last broken tests, the session supplement patch needs some work (especially for 13/16).



-- 
To view, visit https://gerrit.asterisk.org/10652
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I190854dea943d6e441cf03733f8a0da661aea27f
Gerrit-Change-Number: 10652
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 00:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181118/ec1ac86a/attachment.html>