[Asterisk-code-review] Testsuite: find out why chanspy test failed (testsuite[16])
Jenkins2
asteriskteam at digium.com
Sun Nov 18 18:10:00 CST 2018
Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/10662 )
Change subject: Testsuite: find out why chanspy test failed
......................................................................
Testsuite: find out why chanspy test failed
This fixed a bug that caused the testsuite apps/chanspy to fail.
This was due to the following:
1- Adding parameter --no-tcp to pjsua. (Addressed in this review)
2- Building PJSUA with at least one codec (Addressed in another
review)
Change-Id: I937e4bfe185ffa7abac699e008de39c9e83e421d
---
M tests/apps/chanspy/chanspy_w_mixmonitor/run-test
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Corey Farrell: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved
Jenkins2: Approved for Submit
diff --git a/tests/apps/chanspy/chanspy_w_mixmonitor/run-test b/tests/apps/chanspy/chanspy_w_mixmonitor/run-test
index c70374f..39aafc7 100755
--- a/tests/apps/chanspy/chanspy_w_mixmonitor/run-test
+++ b/tests/apps/chanspy/chanspy_w_mixmonitor/run-test
@@ -118,9 +118,9 @@
def start_processes(self):
"""Start up the PJSUA processes"""
LOGGER.info("Starting Processes")
- self.pja = subprocess.Popen(['pjsua', '--local-port=5065', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
- self.pjb = subprocess.Popen(['pjsua', '--local-port=5066', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
- self.pjc = subprocess.Popen(['pjsua', '--local-port=5067', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+ self.pja = subprocess.Popen(['pjsua', '--local-port=5065', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+ self.pjb = subprocess.Popen(['pjsua', '--local-port=5066', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+ self.pjc = subprocess.Popen(['pjsua', '--local-port=5067', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
def stop_processes(self):
"""Stop said processes with prejudice"""
--
To view, visit https://gerrit.asterisk.org/10662
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: I937e4bfe185ffa7abac699e008de39c9e83e421d
Gerrit-Change-Number: 10662
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181118/de77fcd6/attachment.html>
More information about the asterisk-code-review
mailing list