[Asterisk-code-review] stasis: Remove stringfields and lock from change message. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sun Nov 18 18:08:11 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10683 )

Change subject: stasis: Remove stringfields and lock from change message.
......................................................................


Patch Set 1: Code-Review+1

> This is not ABI compatible, but if we're fine with it this can be
 > cherry picked backwards.

I have no opinion on cherry-picking the ABI changes.  If we don't cherry-pick this then we should probably use the NOLOCK option in 13/16.  That won't reduce the number of allocations but will reduce the ao2 memory overhead.


-- 
To view, visit https://gerrit.asterisk.org/10683
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4831931d79f94fd979baf48048738df5dc1632
Gerrit-Change-Number: 10683
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 00:08:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181118/7427a8ad/attachment-0001.html>


More information about the asterisk-code-review mailing list