[Asterisk-code-review] pjproject-bundled: Use AST DEVMODE for conditional compilation. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10657 )

Change subject: pjproject-bundled: Use AST_DEVMODE for conditional compilation.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10657/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10657/2//COMMIT_MSG@9
PS2, Line 9: We previously allowed resample and g711 codecs to be built when
           : TEST_FRAMEWORK was enabled.  This could cause errors if the testsuite
           : was run without this option enabled.  Switch the build system to allow
           : those codecs to be built when --enable-dev-mode is used.  This removes a
           : chance for strange testsuite errors from use of an inadequate pjsua
           : binary.
> I don't think anyone should be running the testsuite without TEST_FRAMEWORK enabled. […]
I agree that TEST_FRAMEWORK should always be enabled to testsuite runs.  The problem which motivated this change is that enabling TEST_FRAMEWORK was not reliably causing the bundled pjproject to be reconfigured.  This resulted in a copy of pjsua that did not contain any codecs.

Others had proposed never disabling those codecs for the bundled pjproject build.  I advocated against that since the resample codec makes libasteriskpj.so.2 600k larger.  I did not want to cause the bundled pjproject build to become unconditionally larger, I think it's acceptable to add potentially unused code for dev mode builds.



-- 
To view, visit https://gerrit.asterisk.org/10657
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8a3613cdb711fa7e7d217c5a775a575907ae22
Gerrit-Change-Number: 10657
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sat, 17 Nov 2018 11:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181117/c9c115db/attachment-0001.html>