[Asterisk-code-review] pjproject-bundled: Use AST DEVMODE for conditional compilation. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10655 )

Change subject: pjproject-bundled: Use AST_DEVMODE for conditional compilation.
......................................................................


Patch Set 3:

> Please change review comment from:
 > "We previously allowed resample and g711 codecs to be built when
 > TEST_FRAMEWORK was enabled"
 > To:
 > "We previously *did not* allow resample and g711 ..."

We did actually allow those codecs to be build when TEST_FRAMEWORK was enabled.  I'm not sure what prevented some systems from rebuilding the bundled pjproject after TEST_FRAMEWORK is enabled.  Without this patch you can enable TEST_FRAMEWORK, run 'git clean -fxdq main third-party' then build and it'll work correctly.


-- 
To view, visit https://gerrit.asterisk.org/10655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8a3613cdb711fa7e7d217c5a775a575907ae22
Gerrit-Change-Number: 10655
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Fri, 16 Nov 2018 17:11:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181116/7140933e/attachment.html>