[Asterisk-code-review] CI: Allow runUnittests to use 'expect' to run the tests (asterisk[13])

Corey Farrell asteriskteam at digium.com
Fri Nov 16 08:35:55 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10658 )

Change subject: CI: Allow runUnittests to use 'expect' to run the tests
......................................................................


Patch Set 1:

(1 comment)

Not worth a -1 but still felt like asking.

https://gerrit.asterisk.org/#/c/10658/1/tests/CI/runUnittests.sh
File tests/CI/runUnittests.sh:

https://gerrit.asterisk.org/#/c/10658/1/tests/CI/runUnittests.sh@3
PS1, Line 3: NOEXPECT=0
Wouldn't NO_EXPECT make more sense so command-line would support --no-expect instead of --noexpect?



-- 
To view, visit https://gerrit.asterisk.org/10658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd656085f854afede813ac241b9e312b31358160
Gerrit-Change-Number: 10658
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Fri, 16 Nov 2018 14:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181116/b0e27284/attachment.html>


More information about the asterisk-code-review mailing list