[Asterisk-code-review] stasis: Segment channel snapshot to reduce creation cost. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10622 )

Change subject: stasis: Segment channel snapshot to reduce creation cost.
......................................................................


Patch Set 5: Code-Review-1

ast_party_*_set and ast_party_*_set_init are a more wide-spread issue.

I think the non-const return from functions like ast_channel_redirecting and ast_channel_caller are a problem for this patch, for example func_callerid has `ast_channel_redirecting(chan)->from.number.str = ast_strdup(value);`.


-- 
To view, visit https://gerrit.asterisk.org/10622
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7ef3df963a88ac47bc187d73c5225c315f8423
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 5
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 15:20:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181113/93b04f8b/attachment.html>