[Asterisk-code-review] stasis: Segment channel snapshot to reduce creation cost. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10622 )

Change subject: stasis: Segment channel snapshot to reduce creation cost.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Appears to be a couple missing invalidates, otherwise looks good.

https://gerrit.asterisk.org/#/c/10622/1/main/channel_internal_api.c
File main/channel_internal_api.c:

https://gerrit.asterisk.org/#/c/10622/1/main/channel_internal_api.c@453
PS1, Line 453: int ast_channel_rings(const struct ast_channel *chan)
Invalidate dialplan.


https://gerrit.asterisk.org/#/c/10622/1/main/channel_internal_api.c@1410
PS1, Line 1410: 	struct ast_channel_id temp;
Invalidate peers?



-- 
To view, visit https://gerrit.asterisk.org/10622
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7ef3df963a88ac47bc187d73c5225c315f8423
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 13:15:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181113/eff5410c/attachment.html>