[Asterisk-code-review] stasis: Segment channel snapshot to reduce creation cost. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10622 )

Change subject: stasis: Segment channel snapshot to reduce creation cost.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/10622/1/main/stasis_channels.c
File main/stasis_channels.c:

https://gerrit.asterisk.org/#/c/10622/1/main/stasis_channels.c@461
PS1, Line 461: 	snapshot = ao2_alloc_options(sizeof(*snapshot), channel_snapshot_dtor,
> Could we have a situation where we could just bump/return the old snapshot?  That is no segments inv […]
I pondered this, but the ripples of trying to get things to a state where it knew it could do this was substantial because of the way some things are accessed through the channel internal API (it returns a flags structure, and that is operated on, so every caller then has to invalidate). To keep it simple I opted not to go down that path.


https://gerrit.asterisk.org/#/c/10622/1/pbx/pbx_realtime.c
File pbx/pbx_realtime.c:

https://gerrit.asterisk.org/#/c/10622/1/pbx/pbx_realtime.c@351
PS1, Line 351: 					/* pbx_exec sets application name and data, but we don't want to log
> Creating/publishing the snapshot from here makes no sense to me. […]
Yeah... I didn't want to touch this minefield...



-- 
To view, visit https://gerrit.asterisk.org/10622
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7ef3df963a88ac47bc187d73c5225c315f8423
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 12:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181113/057684a6/attachment.html>