[Asterisk-code-review] backtrace: Refactor ast bt get symbols so it doesn't crash (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10606 )

Change subject: backtrace:  Refactor ast_bt_get_symbols so it doesn't crash
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10606/4/main/backtrace.c
File main/backtrace.c:

https://gerrit.asterisk.org/#/c/10606/4/main/backtrace.c@42
PS4, Line 42: #undef malloc
            : #undef calloc
            : #undef strdup
            : #undef free
Do not undef these in Asterisk 16+.  Instead you should add:
#define ASTMM_LIBC ASTMM_IGNORE

Put this before the include of "asterisk.h" and it'll prevent astmm.h from interfering.  This doesn't change the need to redefine the ast_* macros.



-- 
To view, visit https://gerrit.asterisk.org/10606
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I79d02862ddaa2423a0809caa4b3b85c128131621
Gerrit-Change-Number: 10606
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 20:52:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181112/cc12724e/attachment.html>