[Asterisk-code-review] res/res pjsip nat Fix logic for REINVITES (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10531 )

Change subject: res/res_pjsip_nat Fix logic for REINVITES
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/10531/4/res/res_pjsip_nat.c
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/#/c/10531/4/res/res_pjsip_nat.c@47
PS4, Line 47: 
You've put a ton of time into this - and have an idea over all of how it "should" work (disregarding how it currently does). So that knowledge/thought isn't lost would it be wise to add a large comment about this function with that so if someone wants to tackle it they'll have a starting point?



-- 
To view, visit https://gerrit.asterisk.org/10531
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ceb54ccfc93f7e315e476c514a2c777f2da7dc
Gerrit-Change-Number: 10531
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 11:48:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181112/cc77070b/attachment.html>