[Asterisk-code-review] vector: Add options for alternate memory management (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10611 )

Change subject: vector:  Add options for alternate memory management
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10611/2/include/asterisk/vector.h
File include/asterisk/vector.h:

https://gerrit.asterisk.org/#/c/10611/2/include/asterisk/vector.h@98
PS2, Line 98: 	(vec)->elems = alloc_size ? (vec)->calloc_fn(1, alloc_size) : NULL;	\
If MALLOC_DEBUG is enabled this allocation will be recorded as belonging to astmm.c instead of the actual location.

I don't like these changes to vector.h.  I think it would be better if backtrace.c just redefined allocators to use the ast_std_* variants.  Then create a backtrace.c function to free the result of __ast_bt_addresses.



-- 
To view, visit https://gerrit.asterisk.org/10611
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d871dfed9ce215fd11aa03e7d6cfaf385b55597
Gerrit-Change-Number: 10611
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Fri, 09 Nov 2018 17:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181109/fd64e716/attachment.html>