[Asterisk-code-review] chan sip: fix Reason-Phrase for 603 Response (asterisk[13])

Frédéric LE FOLL frederic.lefoll at c-s.fr
Tue Nov 6 08:04:28 CST 2018


Hello,

Joshua and Sean, you are right: it is perfectly valid, and there is no 
bug or problem, leaving "603 Declined".

This issue was a more suggestion to come back to default Reason-Phrase 
as proposed by RFC3261 (12 years later, I admit!). And I know RFC3261 
permits other Reason-Phrases (it even sometimes encourages them, when 
they bring more detailed information).
There is indeed no NEED to change.

Best regards,

Frederic

Le 06/11/2018 à 14:53, Sean Bright a écrit :
>
> From Section 7.2 Responses:
>
>   While this specification suggests specific wording for the reason
>   phrase, implementations MAY choose other text, for example, in the
>   language indicated in the Accept-Language header field of the
>   request.
>
> Patch set 1:Code-Review -2
>
> View Change <https://gerrit.asterisk.org/10588>
>
> To view, visit change 10588 <https://gerrit.asterisk.org/10588>. To 
> unsubscribe, or for help writing mail filters, visit settings 
> <https://gerrit.asterisk.org/settings>.
>
> Gerrit-Project: asterisk
> Gerrit-Branch: 13
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I4f94ae98f1cf4302fbad9895cad96eeab8c53269
> Gerrit-Change-Number: 10588
> Gerrit-PatchSet: 1
> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
> Gerrit-Reviewer: Jenkins2 (1000185)
> Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
> Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:53:50 +0000
> Gerrit-HasComments: No
> Gerrit-HasLabels: Yes

-- 
Frederic LE FOLL - CS Systemes d’Information
22, avenue Galilee - 92350 Le Plessis Robinson - FRANCE
Tel. +33 (0)1 41 28 45 59 - mailto:frederic.lefoll at c-s.fr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181106/f1954e72/attachment.html>


More information about the asterisk-code-review mailing list