[Asterisk-code-review] pjsip: New function PJSIP PARSE URI to parse URI and return ... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10577 )

Change subject: pjsip: New function PJSIP_PARSE_URI to parse URI and return part of URI
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Minor tweak. Are you planning to do tests for this?

https://gerrit.asterisk.org/#/c/10577/4/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/10577/4/channels/pjsip/dialplan_functions.c@1092
PS4, Line 1092: 		ast_log(LOG_ERROR, "Failed to get SIP URI\n");
Output the URI here to make it clearer to the user what it was so they don't have to do any hunting.



-- 
To view, visit https://gerrit.asterisk.org/10577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d828fb87f6803b6c1152bb7b44835f027bb9d5a
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 10:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181106/96fa4ad5/attachment.html>