[Asterisk-code-review] pjsip: modify taskprocessor scheduling algorithm from round-... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Mon Nov 5 14:13:07 CST 2018


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10587 )

Change subject: pjsip: modify taskprocessor scheduling algorithm from round-robin to least-size
......................................................................


Patch Set 1:

> (1 comment)
 > 
 > WHY???
 > 
 > Why take something that works and submit a patch that breaks stuff?

The current round-robin method does not take the current taskprocessor load into consideration when distributing requests. Using the least-size method the request goes to the taskprocessor that is servicing the least number of active tasks at the current time.

The long running task on round-robin method can slowdown a fast running tasks.

What does this patch break?


-- 
To view, visit https://gerrit.asterisk.org/10587
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8d8cc2c2490494f579374b6af0a4868e3a37cd
Gerrit-Change-Number: 10587
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 20:13:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/3ac09e63/attachment-0001.html>


More information about the asterisk-code-review mailing list