[Asterisk-code-review] stasis: Add internal filtering of messages. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10479 )

Change subject: stasis: Add internal filtering of messages.
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.asterisk.org/#/c/10479/10/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/10479/10/res/res_pjsip_mwi.c@1370
PS10, Line 1370: 			struct stasis_subscription *sub;
               : 
               : 			sub = stasis_subscribe_pool(ast_manager_get_topic(), mwi_startup_event_cb, NULL);
               : 			stasis_subscription_accept_message_type(sub, ast_manager_get_generic_type());
               : 			stasis_subscription_set_filter(sub, STASIS_SUBSCRIPTION_FILTER_SELECTIVE);
> This appears to be leaking sub (may be missing something though).
It doesn't leak it exactly - mwi_startup_event_cb itself does an unsubscribe which releases the reference that this technically has.



-- 
To view, visit https://gerrit.asterisk.org/10479
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99bee23895baa0a117985d51683f7963b77aa190
Gerrit-Change-Number: 10479
Gerrit-PatchSet: 10
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 19:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/3d0cc5e2/attachment.html>