[Asterisk-code-review] pjsip: New function PJSIP PARSE URI to parse URI and return ... (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10577 )

Change subject: pjsip: New function PJSIP_PARSE_URI to parse URI and return part of URI
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/10577/3/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/10577/3/channels/pjsip/dialplan_functions.c@1068
PS3, Line 1068: 	pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "ParseUri", 128, 128);
> This is violating the PJSIP/Asterisk boundary. […]
I don't understand.
I see a lot of pjsip_endpt_create_pool/pjsip_endpt_release_pool
without dispatching into the PJSIP thread to execute.
For example.
=== inside function channel_read_pjsip ===
                pj_pool_t *pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "secure-check", 128, 128);
                pjsip_get_dest_info(dlg->target, NULL, pool, &dest);
                snprintf(buf, buflen, "%d", dest.flag & PJSIP_TRANSPORT_SECURE ? 1 : 0);
                pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);
======
=== inside function sip_outbound_registration_regc_alloc ===
        pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "URI Validation", 256, 256);
...
        pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);

======



-- 
To view, visit https://gerrit.asterisk.org/10577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d828fb87f6803b6c1152bb7b44835f027bb9d5a
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 17:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/3c4961de/attachment.html>