[Asterisk-code-review] bridge native rtp.c: Fail native bridge if no framing match (asterisk[13])

[Robert Cripps]

Robert Cripps has posted comments on this change. ( https://gerrit.asterisk.org/10495 )

Change subject: bridge_native_rtp.c: Fail native bridge if no framing match
......................................................................


Patch Set 3:

(1 comment)

> (1 comment)

https://gerrit.asterisk.org/#/c/10495/3/bridges/bridge_native_rtp.c
File bridges/bridge_native_rtp.c:

https://gerrit.asterisk.org/#/c/10495/3/bridges/bridge_native_rtp.c@718
PS3, Line 718: 	read_ptime0 = ast_format_cap_get_format_framing(cap0, ast_channel_rawreadformat(bc0->chan));
             : 	read_ptime1 = ast_format_cap_get_format_framing(cap1, ast_channel_rawreadformat(bc1->chan));
             : 	write_ptime0 = ast_format_cap_get_format_framing(cap0, ast_channel_rawwriteformat(bc0->chan));
             : 	write_ptime1 = ast_format_cap_get_format_framing(cap1, ast_channel_rawwriteformat(bc1->chan));
> They are supposed to reflect the negotiated framing, if that was working as expected then this code  […]
So you want me to investigate why they are all set to 20ms?



-- 
To view, visit https://gerrit.asterisk.org/10495
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607
Gerrit-Change-Number: 10495
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Cripps <rcripps at voxbone.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 11:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/5c75a4e9/attachment.html>