[Asterisk-code-review] Certify libsrtp2: Changes in Testsuite to certify libsrtp2 (testsuite[16])

Jenkins2 asteriskteam at digium.com
Mon Nov 5 05:12:34 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/10580 )

Change subject: Certify_libsrtp2: Changes in Testsuite to certify libsrtp2
......................................................................

Certify_libsrtp2: Changes in Testsuite to certify libsrtp2

Two items were changed in testsuite that were causing libsrtp2
tests to fail:
1- Added sending new ACK after receiving 488 on the decline test
2- Change runtests.py line 44 to set asterisk scripts paths
   to first in path list instead of last. Previously set to last
   in line caused an error if other python modules "Asterisk"
   exists in other paths.

Change-Id: Ie7e7f4b1937676f033de8e7f9459594c2a7fcacc
---
M runtests.py
M tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.xml
2 files changed, 19 insertions(+), 2 deletions(-)

Approvals:
  Matthew Fredrickson: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/runtests.py b/runtests.py
index 3fd5b1b..d1bc4aa 100755
--- a/runtests.py
+++ b/runtests.py
@@ -41,7 +41,7 @@
     os.mkdir("logs")
 
 # The current sys.path is only used by runtests.py
-sys.path.append("lib/python")
+sys.path.insert(1,"lib/python")
 # The tests themselves are run in a separate process
 # so we're going to accumulate additional paths in
 # new_PYTHONPATH to pass to the new process.
@@ -51,7 +51,7 @@
 new_PYTHONPATH=[]
 if os.getenv("PYTHONPATH"):
     new_PYTHONPATH.append(os.getenv("PYTHONPATH"))
-new_PYTHONPATH.append("lib/python")
+new_PYTHONPATH.insert(1,"lib/python")
 
 from asterisk.asterisk import Asterisk
 from asterisk.test_config import TestConfig
diff --git a/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.xml b/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.xml
index ff1acc2..1d2844c 100644
--- a/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.xml
+++ b/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.xml
@@ -43,6 +43,23 @@
   <recv response="488" rtd="true">
   </recv>
 
+  <send>
+    <![CDATA[
+
+      ACK sip:echo@[remote_ip]:[remote_port] SIP/2.0
+      Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
+      From: test1 <sip:alice@[local_ip]:[local_port]>;tag=[call_number]
+      To: test <sip:test@[remote_ip]:[remote_port]>[peer_tag_param]
+      Call-ID: [call_id]
+      CSeq: 1 ACK
+      Contact: sip:test@[local_ip]:[local_port]
+      Max-Forwards: 70
+      Subject: Test
+      Content-Length: 0
+
+    ]]>
+  </send>
+
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
 

-- 
To view, visit https://gerrit.asterisk.org/10580
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7e7f4b1937676f033de8e7f9459594c2a7fcacc
Gerrit-Change-Number: 10580
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/9adc58fc/attachment-0001.html>


More information about the asterisk-code-review mailing list