[Asterisk-code-review] Certify libsrtp2: Changes in Testsuite to certify libsrtp2 (testsuite[16])

Corey Farrell asteriskteam at digium.com
Thu Nov 1 13:34:17 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10580 )

Change subject: Certify_libsrtp2: Changes in Testsuite to certify libsrtp2
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10580/1/runtests.py
File runtests.py:

https://gerrit.asterisk.org/#/c/10580/1/runtests.py@44
PS1, Line 44: sys.path.insert(1,"lib/python")
new_PYTHONPATH.append("lib/python") on line 54 is what is used by the actual test processes.  Without knowing much about this change I think it would be better if new_PYTHONPATH were setup the same way as sys.path.



-- 
To view, visit https://gerrit.asterisk.org/10580
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7e7f4b1937676f033de8e7f9459594c2a7fcacc
Gerrit-Change-Number: 10580
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Thu, 01 Nov 2018 18:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181101/a3cb8bf0/attachment.html>


More information about the asterisk-code-review mailing list