[Asterisk-code-review] app confbridge: Add talking indicator for ConfBridgeList AMI... (asterisk[13])

William McCall asteriskteam at digium.com
Wed May 30 23:37:28 CDT 2018


William McCall has posted comments on this change. ( https://gerrit.asterisk.org/9060 )

Change subject: app_confbridge: Add talking indicator for ConfBridgeList AMI response
......................................................................


Patch Set 3:

(1 comment)

Would also like to discuss this item when you get around to it.

https://gerrit.asterisk.org/#/c/9060/3/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9060/3/apps/app_confbridge.c@3540
PS3, Line 3540: 		"Talking: %s\r\n"
This is shown even when talk_detection_events=no. Should this only be shown conditionally?



-- 
To view, visit https://gerrit.asterisk.org/9060
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b5284f34966c3fda94f5b99a7e40e6b89767c6
Gerrit-Change-Number: 9060
Gerrit-PatchSet: 3
Gerrit-Owner: William McCall <william.mccall at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: William McCall <william.mccall at gmail.com>
Gerrit-Comment-Date: Thu, 31 May 2018 04:37:28 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180530/ea5663f6/attachment.html>


More information about the asterisk-code-review mailing list