[Asterisk-code-review] app confbridge: Add talking indicator for ConfBridgeList AMI... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9060 )

Change subject: app_confbridge: Add talking indicator for ConfBridgeList AMI response
......................................................................


Patch Set 3:

> > Hey William,
 > >
 > > As far as technical reviews go, this looks really good, but in
 > > order to put this patch into 13/15 we need testsuite tests
 > > contributed.
 > >
 > > The master version of the patch should be good to go, since tests
 > > aren't required for contributions to the master branch.
 > 
 > OOops.  Forgot to also mention that in addition to testsuite tests,
 > this will require an AMI version bump as well.

Speaking of documentation about when this functionality goes in, because of an AMI version bump, a note in CHANGES in the appropriate spot would be needed too.  The appropriate spot depends upon if there are testsuite tests created for the v13/v15 version of the patch or if this patch only goes into master.


-- 
To view, visit https://gerrit.asterisk.org/9060
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b5284f34966c3fda94f5b99a7e40e6b89767c6
Gerrit-Change-Number: 9060
Gerrit-PatchSet: 3
Gerrit-Owner: William McCall <william.mccall at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: William McCall <william.mccall at gmail.com>
Gerrit-Comment-Date: Wed, 30 May 2018 15:29:19 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180530/731f5739/attachment.html>