[Asterisk-code-review] app confbridge: Add talking indicator for ConfBridgeList AMI... (asterisk[13])
Matthew Fredrickson
asteriskteam at digium.com
Wed May 30 09:42:31 CDT 2018
Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/9060 )
Change subject: app_confbridge: Add talking indicator for ConfBridgeList AMI response
......................................................................
Patch Set 3: Code-Review-1
Hey William,
As far as technical reviews go, this looks really good, but in order to put this patch into 13/15 we need testsuite tests contributed.
The master version of the patch should be good to go, since tests aren't required for contributions to the master branch.
--
To view, visit https://gerrit.asterisk.org/9060
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b5284f34966c3fda94f5b99a7e40e6b89767c6
Gerrit-Change-Number: 9060
Gerrit-PatchSet: 3
Gerrit-Owner: William McCall <william.mccall at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: William McCall <william.mccall at gmail.com>
Gerrit-Comment-Date: Wed, 30 May 2018 14:42:31 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180530/07f40592/attachment.html>
More information about the asterisk-code-review
mailing list