[Asterisk-code-review] bridge channel.c: Fix Deadlock when using Local channels and... (asterisk[13])

Pirmin Walthert asteriskteam at digium.com
Wed May 30 01:31:17 CDT 2018


Pirmin Walthert has uploaded a new patch set (#2). ( https://gerrit.asterisk.org/9069 )

Change subject: bridge_channel.c: Fix Deadlock when using Local channels and fax gateway
......................................................................

bridge_channel.c: Fix Deadlock when using Local channels and fax gateway

ast_indicate is invoked with the bridge locked. As ast_indicate locks the
other end of the bridge as well this can lead to a deadlock in some situations.
(Especially when a different thread does the same in the reverse order).
This patch calls ast_indicate after unlocking the bridge, what fixes the
deadlock. Calling ast_indicate with these parameters without locking the
bridge should be safe as this is done at different places without a
bridge lock.

ASTERISK-27094 #close
Reported-by: David Brillert

Change-Id: I5f86c1e2ce75b9929a36ab589b18c450e62ea35f
---
M main/bridge_channel.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/9069/2
-- 
To view, visit https://gerrit.asterisk.org/9069
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f86c1e2ce75b9929a36ab589b18c450e62ea35f
Gerrit-Change-Number: 9069
Gerrit-PatchSet: 2
Gerrit-Owner: Pirmin Walthert <infos at nappsoft.ch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180530/f4d3a5a4/attachment.html>


More information about the asterisk-code-review mailing list