[Asterisk-code-review] rtp engine: Allow Media Formats with add static payload(-1) ... (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Fri May 18 16:42:30 CDT 2018


Kevin Harwell has submitted this change and it was merged. ( https://gerrit.asterisk.org/8968 )

Change subject: rtp_engine: Allow Media Formats with add_static_payload(-1) on egress again.
......................................................................

rtp_engine: Allow Media Formats with add_static_payload(-1) on egress again.

This issue affected only installations with rtp_use_dynamic=yes in asterisk.conf
which is the default since Asterisk 15. Codec 2 and SiLK were built-in examples
of media formats which were affected.

ASTERISK-27850
Reported by: Dinis Brazão, Selene Feigl

Change-Id: I08c1e76433a67e4350141d38cacf3a1cb5086496
---
M main/rtp_engine.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit



diff --git a/main/rtp_engine.c b/main/rtp_engine.c
index 627605a..97455df 100644
--- a/main/rtp_engine.c
+++ b/main/rtp_engine.c
@@ -1545,7 +1545,7 @@
 	if (!explicit) {
 		payload = find_static_payload_type(asterisk_format, format, code);
 
-		if (payload < 0 && (!asterisk_format || ast_option_rtpusedynamic)) {
+		if (payload < 0 && (!asterisk_format || !ast_option_rtpusedynamic)) {
 			return payload;
 		}
 	}

-- 
To view, visit https://gerrit.asterisk.org/8968
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08c1e76433a67e4350141d38cacf3a1cb5086496
Gerrit-Change-Number: 8968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180518/9c0b6196/attachment.html>


More information about the asterisk-code-review mailing list