[Asterisk-code-review] netsock2: Add ast sockaddr resolve first af to netsock2 publ... (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/8987 )

Change subject: netsock2: Add ast_sockaddr_resolve_first_af to netsock2 public API
......................................................................


Patch Set 2: Code-Review+1

(4 comments)

All 4 are minor things that I don't really care about being changed or not, everything looks fine to me!

https://gerrit.asterisk.org/#/c/8987/2/include/asterisk/netsock2.h
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/#/c/8987/2/include/asterisk/netsock2.h@448
PS2, Line 448: funcion
function*


https://gerrit.asterisk.org/#/c/8987/2/include/asterisk/netsock2.h@449
PS2, Line 449: str
str or name?


https://gerrit.asterisk.org/#/c/8987/2/include/asterisk/netsock2.h@460
PS2, Line 460: str
str or name?


https://gerrit.asterisk.org/#/c/8987/2/include/asterisk/netsock2.h@467
PS2, Line 467: specity
specify*



-- 
To view, visit https://gerrit.asterisk.org/8987
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52e23be885601c51d70259f62de1a5e59d38d04
Gerrit-Change-Number: 8987
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 17 May 2018 20:21:56 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180517/23f027ee/attachment.html>