[Asterisk-code-review] utils socket: Set option to reuse socket (testsuite[13])

Corey Farrell asteriskteam at digium.com
Wed May 9 08:42:52 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8941 )

Change subject: utils_socket: Set option to reuse socket
......................................................................


Patch Set 1: Code-Review-1

Per discussion on IRC I think this patch is incorrect, I don't think the issue can be fixed from the testsuite.  The correct way forward is to fix the bug in sipp.

https://github.com/SIPp/sipp/pull/344

Once the fixed sipp is installed to jenkins agents we should revert all utils_socket.py patches.  FYI I've retested 'self_test' with utils_socket reverted, it seems to work fine even if no tests exist in lib/python/asterisk/self_test.  So we do not need to worry about that during the revert.


-- 
To view, visit https://gerrit.asterisk.org/8941
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb84e77c8825310f1c10f21c54b19c4ed694175
Gerrit-Change-Number: 8941
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 09 May 2018 13:42:52 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180509/c4109aaa/attachment-0001.html>


More information about the asterisk-code-review mailing list