[Asterisk-code-review] manager: fix digest auth for ami/http mechanism. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8938 )

Change subject: manager: fix digest auth for ami/http mechanism.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8938/3/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/8938/3/main/manager.c@8017
PS3, Line 8017: 			return 0;
You need to unlock the users list before returning:

 AST_RWLIST_UNLOCK(&users);


https://gerrit.asterisk.org/#/c/8938/3/main/manager.c@8031
PS3, Line 8031: 		ast_free(a2);
Move this up to line 8021. That is the last time that a2 is used.



-- 
To view, visit https://gerrit.asterisk.org/8938
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I660609db13b8f9e5f9567f339dd804f4985d41b3
Gerrit-Change-Number: 8938
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 08 May 2018 12:36:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180508/fee8fef7/attachment.html>