[Asterisk-code-review] manager: fix digest auth for ami/http mechanisms. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8933 )

Change subject: manager: fix digest auth for ami/http mechanisms.
......................................................................


Patch Set 1: Code-Review-1

> It would result in less code at the 'expense' of malloc'ing instead
 > of stack allocating.

Although the risk here is low malloc (ast_asprintf) cannot cause the system to crash, in theory stack allocation can.  Additionally I suspect ast_asprintf will result in code that is simpler / easier to read.

My vote is for using ast_asprintf here, I don't like using alloca where the size is determined by untrusted input.


-- 
To view, visit https://gerrit.asterisk.org/8933
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc5d148fd1ee6687a0f6680635ad16e34c5f01a
Gerrit-Change-Number: 8933
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 07 May 2018 15:19:41 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180507/6c0ace48/attachment.html>