[Asterisk-code-review] app macro: Prevent infinite loop in find matching priority. (asterisk[15])

Corey Farrell asteriskteam at digium.com
Mon May 7 09:00:48 CDT 2018


Hello Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8930

to look at the new patch set (#2).

Change subject: app_macro: Prevent infinite loop in find_matching_priority.
......................................................................

app_macro: Prevent infinite loop in find_matching_priority.

Use AST_PBX_MAX_STACK to escape if we recurse 128 times.  This will
prevent crash if dialplan contains an include loop.  Log an error when
this occurs, at most one message per call to Macro() so we avoid logger
spam.

ASTERISK-26570 #close

Change-Id: I6c71b76998c31434391b150de055ae9a531e31da
---
M apps/app_macro.c
1 file changed, 16 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/8930/2
-- 
To view, visit https://gerrit.asterisk.org/8930
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c71b76998c31434391b150de055ae9a531e31da
Gerrit-Change-Number: 8930
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180507/2ed60018/attachment-0001.html>


More information about the asterisk-code-review mailing list