[Asterisk-code-review] stream: Make the topology a reference counted object. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu May 3 12:36:10 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8927 )

Change subject: stream: Make the topology a reference counted object.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/8927/1/include/asterisk/stream.h
File include/asterisk/stream.h:

https://gerrit.asterisk.org/#/c/8927/1/include/asterisk/stream.h@352
PS1, Line 352: void ast_stream_topology_free(struct ast_stream_topology *topology);
A good follow up for master is to remove this function and make it a define alias to ao2_cleanup().  This way ref debug can better track where the object was unreffed.



-- 
To view, visit https://gerrit.asterisk.org/8927
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4d3dd856a033ed55fe218c3a4fab364afedb03
Gerrit-Change-Number: 8927
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 03 May 2018 17:36:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/09304bf6/attachment-0001.html>


More information about the asterisk-code-review mailing list