[Asterisk-code-review] cdr mysql: split mysql init out of my load module (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8919 )

Change subject: cdr_mysql: split mysql init out of my_load_module
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8919/1/addons/cdr_mysql.c
File addons/cdr_mysql.c:

https://gerrit.asterisk.org/#/c/8919/1/addons/cdr_mysql.c@546
PS1, Line 546: 				return AST_MODULE_LOAD_DECLINE;
While it's unlikely to help things if we run out of memory, we should clean up as much as possible in the event of a failure.



-- 
To view, visit https://gerrit.asterisk.org/8919
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ee676056067cc693ff08be68ee4944bf35b49f
Gerrit-Change-Number: 8919
Gerrit-PatchSet: 1
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 17:21:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/59cf32a0/attachment.html>