[Asterisk-code-review] cdr mysql: check early for missing configs (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8921 )

Change subject: cdr_mysql: check early for missing configs
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Mostly just cosmetic things

https://gerrit.asterisk.org/#/c/8921/1/addons/cdr_mysql.c
File addons/cdr_mysql.c:

https://gerrit.asterisk.org/#/c/8921/1/addons/cdr_mysql.c@584
PS1, Line 584: static const char * my_global_var(ast_config *cfg, const char *var_name)
Remove space after the first '*'


https://gerrit.asterisk.org/#/c/8921/1/addons/cdr_mysql.c@590
PS1, Line 590: const char[] required_global_cfgs[] = {
Should this be static?


https://gerrit.asterisk.org/#/c/8921/1/addons/cdr_mysql.c@598
PS1, Line 598: 	if (! (my_global_var(cfg, "hostname") || my_global_var(cfg, "dbsock")))	{
Remove space after '!'


https://gerrit.asterisk.org/#/c/8921/1/addons/cdr_mysql.c@609
PS1, Line 609: 
Remove blank line



-- 
To view, visit https://gerrit.asterisk.org/8921
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5126f525fb255574bbf44878059a8d1890843fc
Gerrit-Change-Number: 8921
Gerrit-PatchSet: 1
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 17:18:26 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/62f77240/attachment.html>