[Asterisk-code-review] res ari: Remove requirement that body exists when debug is on. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Thu May 3 11:48:11 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8912 )

Change subject: res_ari: Remove requirement that body exists when debug is on.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8912/1/res/res_ari.c
File res/res_ari.c:

https://gerrit.asterisk.org/#/c/8912/1/res/res_ari.c@942
PS1, Line 942: 		if (!body) {
             : 			switch (errno) {
> This doesn't fully work. ast_json_dump_string_format returns NULL.
ast_json_dump_string_format() returns NULL because body is NULL.  When body is the null json object it should be returning the string "null".



-- 
To view, visit https://gerrit.asterisk.org/8912
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eef036ad54550a4368118cc348765ecac25e0f8
Gerrit-Change-Number: 8912
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 03 May 2018 16:48:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/d6b222d9/attachment.html>


More information about the asterisk-code-review mailing list