[Asterisk-code-review] cdr mysql: run a full reconnect on log if not connected (asterisk[master])

Tzafrir Cohen asteriskteam at digium.com
Thu May 3 10:57:51 CDT 2018


Hello Matthew Fredrickson, Kevin Harwell, Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7928

to look at the new patch set (#2).

Change subject: cdr_mysql: run a full reconnect on log if not connected
......................................................................

cdr_mysql: run a full reconnect on log if not connected

If the MySQL CDR backend is not connected at startup, it will try to
reconnect (with a reloaded configuration) each time it needs to log a
record.

However it does not run the full connection startup sequence and thus
fails to set up the columns to log. As a result all subsequent records
will be empty.

This commit makes the mysql backend run the same connection sequence in
that case as it does on module load.

ASTERISK-27572 #close

Change-Id: I7603c7501dae7070fac35081cf35161579c47590
---
M addons/cdr_mysql.c
1 file changed, 25 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/28/7928/2
-- 
To view, visit https://gerrit.asterisk.org/7928
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7603c7501dae7070fac35081cf35161579c47590
Gerrit-Change-Number: 7928
Gerrit-PatchSet: 2
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/b93920c3/attachment-0001.html>


More information about the asterisk-code-review mailing list