[Asterisk-code-review] Add support code for Python 3 (starpy[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8918 )

Change subject: Add support code for Python 3
......................................................................


Patch Set 1:

(1 comment)

Revision 1 of this review is posted from the github.com pull request.  I only rebased to current master and amended the commit message to have the Change-Id added.

Also posted comment from github to get comments from gerrit reviewers.

https://gerrit.asterisk.org/#/c/8918/1/starpy/manager.py
File starpy/manager.py:

https://gerrit.asterisk.org/#/c/8918/1/starpy/manager.py@122
PS1, Line 122:         types = [str, type(None)]
             :         if sys.version_info <= (3, 0):
             :             types.append(unicode)
             :         if isinstance(event, tuple(types)):
             :             event = (event,)
This (and the second copy of the same code) could either:
* Use six.string_types
* Use a locally implemented function of the same
* Left alone.

Personally I prefer a local function, I don't think this one feature is worth adding an external dependency.



-- 
To view, visit https://gerrit.asterisk.org/8918
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ccd5a15be6e4129a5e0ce0bf1a5a4ff26998bac
Gerrit-Change-Number: 8918
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Comment-Date: Thu, 03 May 2018 13:01:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/3acdbc19/attachment-0001.html>