[Asterisk-code-review] sipp, test suite utils: Default media port to an unused port (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8691 )

Change subject: sipp, test_suite_utils: Default media port to an unused port
......................................................................


Patch Set 1:

> My concern was/is that get_available_port binds a socket, gets the
 > port, closes the socket, then returns the port.  What would stop
 > the very next call to get_available_port from returning the same
 > port?  I think this assumes that s.bind('', 0) will not bind the
 > same port twice in a row?
 > 

I don't think anything would stop it and yeah it seems it would be possible for it to return the same port twice.

 > In any case I wonder if maybe the appropriate fix is to patch sipp
 > itself?

Probably, but for now if people are okay with this we can use this workaround.


-- 
To view, visit https://gerrit.asterisk.org/8691
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00
Gerrit-Change-Number: 8691
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 22:04:04 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180328/94ce9fdd/attachment.html>