[Asterisk-code-review] res rtp asterisk: Add support for raising additional RTCP me... (asterisk[15])

Joshua Colp asteriskteam at digium.com
Tue Mar 27 09:38:54 CDT 2018


Hello Benjamin Keith Ford, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8634

to look at the new patch set (#4).

Change subject: res_rtp_asterisk: Add support for raising additional RTCP messages.
......................................................................

res_rtp_asterisk: Add support for raising additional RTCP messages.

This change extends the existing AST_FRAME_RTCP frame type to be
able to contain additional RTCP message types, such as feedback
messages. The payload type is contained in the subclass which allows
knowing what is in the frame itself.

The RTCP feedback message type is now handled and REMB[1] messages
are raised with their containing information.

This also fixes a bug where all feedback messages were triggering
video updates instead of just FIR and FUR.

Finally RTCP frames are now passed up through the Asterisk core to
what is handling the channel, mapped appropriately in the case of
bridging, and written to an outgoing stream. Since RTCP frames are
on a per-stream basis this is only done on multistream capable
channels.

[1] https://tools.ietf.org/html/draft-alvestrand-rmcat-remb-03

ASTERISK-27758
ASTERISK-26366

Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e
---
M channels/chan_pjsip.c
M codecs/codec_speex.c
M include/asterisk/frame.h
M include/asterisk/rtp_engine.h
M main/bridge_channel.c
M main/channel.c
M res/res_rtp_asterisk.c
7 files changed, 104 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/34/8634/4
-- 
To view, visit https://gerrit.asterisk.org/8634
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e
Gerrit-Change-Number: 8634
Gerrit-PatchSet: 4
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180327/fb98fc23/attachment.html>


More information about the asterisk-code-review mailing list