[Asterisk-code-review] BuildSystem: Go for Python 2 explicitly, because that is cur... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8673 )

Change subject: BuildSystem: Go for Python 2 explicitly, because that is currently needed.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/8673/1/configure.ac
File configure.ac:

https://gerrit.asterisk.org/#/c/8673/1/configure.ac@264
PS1, Line 264: AC_PATH_PROGS([PYTHON], [python2 python2.7], :)
> 8646 and cherry-picks are close to having full support for the build system
When you are done with your change, you can change that back.


https://gerrit.asterisk.org/#/c/8673/1/configure.ac@2313
PS1, Line 2313: AST_PKG_CONFIG_CHECK([PYTHONDEV], [python < 3])
              : AST_PKG_CONFIG_CHECK([PYTHONDEV], [python2])
              : AST_PKG_CONFIG_CHECK([PYTHONDEV], [python-2.7])
> Maybe I missed it in the bug report but why is this needed?  I understand t
NetBSD requires 'python-2.7' because it does not allow python or python2 via pkg-config. That was how everything started.

python2 is for those platforms which do not allow version comparison at all or via major versions. This is Gentoo Linux and Arch Linux, if I am not totally wrong now. Actually, this is more a preparation for python3 one day: On all (other) tested platforms, python >= 3 does not work because pkg-config does not understand that python2 and python3 are both 'python'. So when somebody changes this to >= 3/3/-3.6 one day, nothing breaks.

Actually, actually, today, all we need is 'python-2.7', because all other versions are out of support and this works on all platforms (except CentOS 6 with its Python 2.6). However, George did not like that but failed to reason why.



-- 
To view, visit https://gerrit.asterisk.org/8673
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e694dc7e92510dc26b15895b55f78f67146b2c
Gerrit-Change-Number: 8673
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 27 Mar 2018 13:35:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180327/40a8dee6/attachment.html>