[Asterisk-code-review] Revert "BuildSystem: In NetBSD, the Python Programming Langu... (asterisk[master])

Alexander Traud asteriskteam at digium.com
Tue Mar 27 06:25:06 CDT 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8626 )

Change subject: Revert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."
......................................................................


Patch Set 1:

> It's python3-devel.  If it's installed then the runtime environment
 > may be 2.7 but the headers will be 3.6.  This causes the build of
 > the pjsua python bindings to fail.

Thank you for adding me as reviewer. Otherwise I would have not been aware of this revert. I would have preferred that the issue report is re-opened too (or at least instead of adding me as reviewer). That way, I would have been informed as well and the issue stayed on track.

Furthermore, it is OK to revert a change which breaks something on a officially supported platform. However, not only a revert but also a bug report should be done. It does not have to be a full analysis, but the steps to reproduce the issue. If even that is too much, at least the symptoms you see (the error message you see) should be mentioned word for word. It took me *four* hours just to reproduce your issue. Yes, that was because of three misunderstandings of mine. Anyway, those would have been avoided by creating steps to reproduce your issue. These four hours could have been used for other stuff.

On behalf of you, I created that report, to be able to *continue* with this change and solve that issue: <https://issues.asterisk.org/jira/browse/ASTERISK-27717#comment-242840>. Please, have a look if that is your scenario so I tackled the right thing.


-- 
To view, visit https://gerrit.asterisk.org/8626
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86dd102eb3ead199fe89178cdbadb36b4e2cfd1b
Gerrit-Change-Number: 8626
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 11:25:06 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180327/a54bbbf7/attachment-0001.html>


More information about the asterisk-code-review mailing list