[Asterisk-code-review] loader: Reserve space for additional pointers in ast module ... (asterisk[master])

Jenkins2 asteriskteam at digium.com
Mon Mar 26 11:44:54 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8621 )

Change subject: loader: Reserve space for additional pointers in ast_module_info.
......................................................................

loader: Reserve space for additional pointers in ast_module_info.

This creates 4 reserved pointers in case we need additional dependency
management fields.

Change-Id: If991ec99b779df1b2dfbd38ce1a0cd79f9e01821
---
M include/asterisk/module.h
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/include/asterisk/module.h b/include/asterisk/module.h
index faa4f7f..08b4c43 100644
--- a/include/asterisk/module.h
+++ b/include/asterisk/module.h
@@ -376,6 +376,13 @@
 	 */
 	const char *enhances;
 
+	/*! These reserved fields should be NULL, they exist to allow addition to this
+	 * structure in a non-breaking way. */
+	void *reserved1;
+	void *reserved2;
+	void *reserved3;
+	void *reserved4;
+
 	/*! The support level for the given module */
 	enum ast_module_support_level support_level;
 };
@@ -448,6 +455,10 @@
 		NULL,                                                          \
 		NULL,                                                          \
 		NULL,                                                          \
+		NULL,                                                          \
+		NULL,                                                          \
+		NULL,                                                          \
+		NULL,                                                          \
 		support_level,                                                 \
 	};                                                                 \
 	static void  __attribute__((constructor)) __reg_module(void)       \

-- 
To view, visit https://gerrit.asterisk.org/8621
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If991ec99b779df1b2dfbd38ce1a0cd79f9e01821
Gerrit-Change-Number: 8621
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180326/a301b743/attachment-0001.html>


More information about the asterisk-code-review mailing list