[Asterisk-code-review] res rtp asterisk: Add support for raising additional RTCP me... (asterisk[15])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/8634 )

Change subject: res_rtp_asterisk: Add support for raising additional RTCP messages.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/8634/2/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/8634/2/main/channel.c@5293
PS2, Line 5293: 		if (ast_channel_tech(chan)->write_stream) {
              : 			if (stream) {
Could these two be merged into one conditional to eliminate one of the two "else"s since they both assign res to 0?



-- 
To view, visit https://gerrit.asterisk.org/8634
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e
Gerrit-Change-Number: 8634
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 22 Mar 2018 20:16:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180322/637cbbf1/attachment.html>